-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Support podOverrides #368
Conversation
3a9e285
to
a33fbca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good.
some docs and a test run are missing
For the docs we have https://docs.stackable.tech/home/nightly/concepts/overrides.html#_pod_overrides, is that sufficient for you? |
It's sufficient for me. I thought we want to link it from the operator docs |
Happy to do so, any recommendation from where exactly we want to link? Goes along with the questions of how hard we want to try to avoid users using podOverrides ^^ |
bors r+ |
# Description *Please add a description here. This will become the commit message of the merge request later.*
Pull request successfully merged into main. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist
Author
Reviewer
Acceptance
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information